Adding requests and limits to Konnector jobs #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwolfin
suggested changes
Jan 4, 2026
| batch: | ||
| backoffLimit: 4 # Maximum number of retries before the job is considered failed. After 4 attempts, the job will fail. | ||
| ttlSecondsAfterFinished: 3600 # Time-to-live for completed jobs, jobs will be automatically deleted 3600 seconds (1 hour) after completion | ||
| cleanupJob: |
There was a problem hiding this comment.
Do we want to think about the backOffLimit and the ttlinSeconds? isn't it related to cleaning up jobs ?
Contributor
Author
There was a problem hiding this comment.
@nwolfin This is for the installer konnector job, not the cleanup job. And I don't think we need backOffLimit for it. (Currently, we remove it once it's finished, so ttlSecondsAfterFinished doesn't make any sense.)
yishaynaPalo
approved these changes
Jan 4, 2026
nwolfin
approved these changes
Jan 4, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
* Feat: Enforce version patterns * Feat: Job history limit (#26) * delete finished jobs after 30 minutes * change jobsHistoryLimit to save only last success and failed job * restore chart version * update chart version * add ttlSecondsAfterFinished value --------- Co-authored-by: yishaynaPalo <[email protected]> * OpenShift Registry Scan Support (#24) * add registry_scan_url optional env * add openshift registry permissions * remove openshift registry permissions * add openshift registry permissions * change env name * restore chart version * bump version --------- Co-authored-by: Yishay Nadav <[email protected]> * Feat: Adding support for priority class (#23) * Adding support for priority class Signed-off-by: Roey <[email protected]> * Add PriorityClass permissions * Add PriorityClass permissions --------- Signed-off-by: Roey <[email protected]> Co-authored-by: ohoffman <[email protected]> * add registry viewer permisssons * Adding requests and limits to Konnector jobs (#29) * Adding resources and limits to Konnector jobs * Reduce cleanup job cpu request * ohoffman/modify priority class default values (#30) * Modify PriorityClass default values to better align with conventions * Increasing PriorityClass default values --------- Co-authored-by: yishaynaPalo <[email protected]> * Modify konnectors' job and chart name to better align with conventions (#31) * Modify konnectors' job and chart name to better align with conventions * Return the name of the helm chart to konnector * Changing konnector job name to cortex-syncer * Release 1.0.24 --------- Signed-off-by: Roey <[email protected]> Co-authored-by: ZurielPalo <[email protected]> Co-authored-by: rlevartovsky <[email protected]> Co-authored-by: ohoffman <[email protected]> Co-authored-by: oded7hoffman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding requests and limits to Konnector jobs
Motivation and Context
We want to uphold the highest standards, and adding requests and limits for the different workloads is a step in the right direction.